Skip to content

Fix sheet component example #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ealmloff merged 1 commit into from
Dec 17, 2025
Merged

Fix sheet component example #174

ealmloff merged 1 commit into from
Dec 17, 2025
+1 −1

Conversation

@Tumypmyp
Copy link
Contributor

@Tumypmyp Tumypmyp commented Dec 17, 2025

Now compiles without the error on newer dx

expected `Option<Result<VNode, RenderError>>`, found `Result<VNode, RenderError>`
   |
   = note: expected enum `std::option::Option<std::result::Result<_, _>>`
              found enum `std::result::Result<_, _>`
   = note: this error originates in the derive macro `Props` (in Nightly builds, run with -Z macro-backtrace for more info)

@ealmloff https://discord.com/channels/899851952891002890/943190605067079712/1450225909931184200

@github-actions
Copy link

github-actions bot commented Dec 17, 2025

Preview available at https://dioxuslabs.github.io/components/pr-preview/pr-174/

@ealmloff
Copy link
Member

ealmloff commented Dec 17, 2025

This should be Element regardless, but I think this was caused by DioxusLabs/dioxus#4995 which was unintentionally breaking

@ealmloff ealmloff merged commit 3564270 into DioxusLabs:main Dec 17, 2025
13 checks passed
@ealmloff ealmloff mentioned this pull request Dec 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ealmloff ealmloff ealmloff approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Tumypmyp @ealmloff